Remove scroll-nojump utility and update layout structure #3494
Conversation
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Eliminated the .scroll-nojump utility and related CSS from globals.css and refactored layout components (Header, Footer, AnnouncementBanner, SpaceLayout) to remove unnecessary wrapper divs. Updated scrollbar styling to use native CSS properties for improved consistency and maintainability.
nolannbiron
force-pushed
the
nolann/fix-scrollbar
branch
from
4a682ae to
0fdb841
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR removes the custom scroll-nojump utility class and simplifies the layout structure by eliminating unnecessary wrapper divs. The changes consolidate scrollbar styling into a more maintainable system using modern CSS properties.
- Removed the
scroll-nojumputility and related CSS for preventing horizontal layout jumps - Updated scrollbar styling to use native CSS properties with improved accessibility support
- Simplified layout components by removing wrapper div elements
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| globals.css | Removes scroll-nojump utility, updates scrollbar styling with modern CSS properties and accessibility features |
| TableOfContents.tsx | Replaces webkit scrollbar styles with hide-scrollbar utility class |
| SpaceLayout.tsx | Removes scroll-nojump wrapper div |
| SiteSectionList.tsx | Removes gutter-stable class from scrollable container |
| SearchContainer.tsx | Adds gutter-stable and pr-1 classes to search popover |
| Header.tsx | Removes scroll-nojump wrapper divs from header sections |
| Footer.tsx | Removes scroll-nojump wrapper div |
| AnnouncementBanner.tsx | Removes scroll-nojump wrapper div |
| AIChat.tsx | Adds gutter-stable class to chat body |
| AIToolCallsSummary.tsx | Adds hide-scrollbar class to search results container |
Comments suppressed due to low confidence (1)
packages/gitbook/src/components/RootLayout/globals.css:1
- The removal of
--scrollbar-width: calc(100vw - 100%);CSS variable may break other parts of the codebase that depend on it. Ensure all references to this variable have been properly updated or removed.
@import "tailwindcss";
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Eliminated the .scroll-nojump utility and related CSS from globals.css and refactored layout components (Header, Footer, AnnouncementBanner, SpaceLayout) to remove unnecessary wrapper divs. Updated scrollbar styling to use native CSS properties for improved consistency and maintainability.